r2modmanPlus icon indicating copy to clipboard operation
r2modmanPlus copied to clipboard

Adds compatibility with steam flatpak.

Open PedroVH opened this issue 2 years ago • 12 comments

PedroVH avatar Aug 19 '23 19:08 PedroVH

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 19 '23 19:08 CLAassistant

Was just looking into making these changes myself! Glad I checked the list of PR. I am running Fedora with Steam installed as a flatpak and r2modman as an PRM package. I think this should solve the issues I am seeing by correctly calling the flatpak steam executable. Let me know if you would like me to build and test this, else I will wait for it to be merged.

lbrunkho avatar Aug 25 '23 06:08 lbrunkho

This looks to be a duplicate of #798.

bb010g avatar Oct 18 '23 16:10 bb010g

If this gets merged in, I can make a request on flathub forms.

In the event the maintainers don't want to ship a flatpak themselves.

lbrunkho avatar Nov 26 '23 18:11 lbrunkho

The goal of this PR is to make r2modman compatible with steam flatpak. This other PR does the same thing AND also makes necessary changes to pack r2modman as a flatpak.

Since that fork was not being maintained, I made my fork based on my needs. I'm keeping it in sync with the official releases, and I'm packaging to pacman, so if anyone wants to use that just go to the releases page in my fork. Also if anyone wants it packaged in another way just ping me

PedroVH avatar Dec 05 '23 02:12 PedroVH

If it were an rpm that would be a bit more convenient for me personally, but I can still run the program as it is now.

Mervius avatar Dec 11 '23 08:12 Mervius

If it were an rpm that would be a bit more convenient for me personally, but I can still run the program as it is now.

@Mervius Check the latest release in my fork, just added other packagings. I haven't tested besides pacman tho

PedroVH avatar Dec 11 '23 08:12 PedroVH

the rpm seems to work fine from what I can tell.

Mervius avatar Dec 11 '23 08:12 Mervius

I've been trying to get r2modman to work with Flatpak and couldn't as it wouldn't accept the steam binary in the relevant flatpak dirs for steam. Running @PedroVH fork immediately worked for me.

Would be great to see this merged in some capacity.

(Tested appimage from fork releases)

fanuch avatar Dec 22 '23 00:12 fanuch

This fix is really important to me. I didn't realize when I switched to Flatpak Steam, that it would break r2modman. I would love to see this PR reviewed and merged soon.

JustinLex avatar Jan 03 '24 08:01 JustinLex

#!/bin/sh

sed -i '/#!\/usr\/bin\/env bash/aif [ -z $FLATPAK_ID ]; then\n  exec flatpak run com.valvesoftware.Steam $@\nfi' $HOME/.var/app/com.valvesoftware.Steam/data/Steam/steam.sh

r2modman.AppImage

Here is my janky script to make it work without any changes to r2modman. Put this & the r2modman AppImage in your PATH (e.g ~/.local/bin). This just inserts a preample in steam.sh to re-exec in the flatpak context.

It needs to be re-inserted everytime since Steam detects the change and overwrites it (which also means a slow Steam startup).

craigcabrey avatar Apr 16 '24 03:04 craigcabrey