ebkr
Add mod filtering by date
To reply to this: https://github.com/ebkr/r2modmanPlus/pull/1010#pullrequestreview-1399965452
The date filters are placed in a modal that's opened via "Filter Categories" button. Do users find the filter from there?
Answer: I'm not sure if I should go and change anything else than the date picker stuff, but I'll be a rebel and change the text to be "Edit filters".
Within the modal, we first have category picker, then some date fields and then at the bottom there's category-related radio buttons. Should the category stuff be grouped together?
Answer: I've moved the date pickers to the bottom at least 🤷
Minor thing but user can pick an end data that precedes the start date. If the library supports preventing this easily, might be worth to do it?
Answer: I couldn't get the date disabling working with the new quasar date picker. I'd say let's leave it out of this implementation now, since it's not really a problem if people select a date in the future. Maybe they'll time travel and get future mods 👁️
On light mode, a focus ring around the date field is nigh invisible. This might be a global issue for the white theme and outside the scope of this PR. But if it applies only to the new fields, it could be nice to address it.
Answer: With quasar date picker it looks a bit neater
- Works on r2mm, but I don't see the calendars on tsmm. Is this intentional at this point?
I'm not sure why it's not showing in tsmm for you, but I'll go check it and make sure it's showing there also 👍
- I can't seem to select just on date (e.g. "today"), always have to choose a range of at least two days
Seems like the selection of a single day was added at a later quasar version. Couldn't pinpoint exact version, cause I didn't want to use that much time to read through the quasar code. (it's a bit complex IMO). I've added support for single day selection though, in the case if the quasar is updated in the future.
I know it's a small QoL hit, but I'd be willing to make this sacrifice right now. It seems like it would be awfully a lot of work, compared to the gain. I'd rater have this whole feature in with this short coming, than not have it there at all.
Do let me know if you differ in opinion 👍
Couple of questions as I'm going through some backlog stuff:
- Did we still want to progress this?
- Would it be worth picking back up post Quasar Upgrade branch merge?
- Can you remove the date filters entirely if you wanted to de-filter your search results?
