try-puppeteer icon indicating copy to clipboard operation
try-puppeteer copied to clipboard

Potential Memory Leak??

Open Edison-Hsu opened this issue 7 years ago • 2 comments

Hi, Thank you for nice puppeteer project.

I finished my puppeteer project by reference backend/server.js file. In my case, I got a little memory leak. Because I did not call browser.disconnect() before reusing the browser object.

I read the backend/server.js file again. I did not find codes be related with disconnect browser. So I guess maybe try-puppeteer got the same memory leak problem ?

Edison-Hsu avatar Feb 24 '18 14:02 Edison-Hsu

Yea good call. There should probably be a disconnect somewhere just to be safe. Want to submit a PR?

ebidel avatar Feb 24 '18 17:02 ebidel

Sure. My pleasure.

Edison-Hsu avatar Feb 25 '18 06:02 Edison-Hsu