filer.open should not ignore onError

Open shabunc opened this issue 12 years ago • 2 comments

Hi there, Eric!

I just believe that filer.open should not ignore second param, onError (just as it claimed in docs). Here's a small fix for this.

If this was intentional or this pull request is inappropriate for some other reason, please, just let all of us know (by "us" I mean the community as a whole ))). If for some reasons this PR should be somehow improve, I'll be glad to fix all that needed.

It's just that, from my practise, it is almost always better to create issue and a pull request than only issue. Especially when it looks like you are talking about bug, not some new functionality :)

Oct 02 '13 12:10 shabunc

Thanks for fixing this.

Oct 16 '13 19:10 luv2code

Oh, I've been on my vacation and now I'm glad to be back. I'll fix code style and check out the tests. If needed, will add news. Just give me a couple of days )

Oct 31 '13 16:10 shabunc