Eric Bidelman comments

Results 306 comments of


                                            Eric Bidelman

Add a "reinitialize" method

We should fix the issues rather than provide a workaround.

Changing google-map language dynamically

Related: https://github.com/GoogleWebComponents/google-map/issues/328 and https://github.com/GoogleWebComponents/google-apis/issues/67

fix map not showing up when first initialized without a height

This shouldn't be needed. These styles are within shadow dom. Can you post a jsbin that repos the issue you're seeing?

fix map not showing up when first initialized without a height

There's workarounds posted in https://github.com/GoogleWebComponents/google-map/issues/259#issuecomment-184753203 on how to resize the map with iron-pages. One good technique is to wrap `` with a conditional `` and make the conditional bound to...

Use DOM for marker content (allows listeners to work)

@tst-dhudlow can you take a look at my comments? Interested in getting this merged.

Use DOM for marker content (allows listeners to work)

I think my comments in https://github.com/GoogleWebComponents/google-map/pull/294#discussion_r67224111 still need to be addressed.

Use DOM for marker content (allows listeners to work)

I'm hesitate to support custom info windows. It's not a common case. Could you not add custom info windows yourself with the underlying api calls? On Thu, Jun 30, 2016,...

google-analytics-chart 'data' property does not notify

Yea that makes sense to me. PR would be great!

Adds a geojsonUrl attribute to load geojson data onto the Map.

There's some previous convo/thoughts here: https://github.com/GoogleWebComponents/google-map/issues/24

Chart as "rendered" but is not visible

FWIW, gwc.github.io should be considered deprecated now that we're hosting the elements at https://elements.polymer-project.org/elements/google-analytics?view=demo:demo/index.html&active=google-analytics-query. The latter works. The `@demo` link was missing from the docs, which is why it wasn't...