TextSummarizer icon indicating copy to clipboard operation
TextSummarizer copied to clipboard

Edit output path to root instead of bin folder

Open KevinLamb opened this issue 6 years ago • 3 comments

Couldn't run due to an error on line 34 of WordPOSTagger.cs related to the ModelPath being set with AppDomain.CurrentDomain.BaseDirectory. AppDomain.CurrentDomain.BaseDirectory was returning the bin folder instead of the application root.

Edit: I plan on trying out a couple loggers after this.

KevinLamb avatar Jun 22 '18 00:06 KevinLamb

Perfect! Thanks for taking a look at this. I plan on going through this change at some point over this weekend. 👍

rohitshubham avatar Jun 22 '18 17:06 rohitshubham

@KevinLamb Thanks for looking into this, We can try to stay with the default .Net configuration structure, it will ease to other developers, they will get a solution to the output directory as default.

$(SolutionDir)bin\Debug or $(SolutionDir)bin\Release

For path issue, can we go through other options?

AppDomain.BaseDirectory Property

eigenharsha avatar Jun 24 '18 08:06 eigenharsha

@eigenharsha Yep, that makes sense. I made another commit that simply changed the ModelPath variables to point two directories up. If it's planned that this gets used in ASP.NET apps then we'd need to change it. AppDomain.CurrentDomain.BaseDirectory returns the root folder instead of the Debug or Release folder for ASP.NET applications.

KevinLamb avatar Jun 24 '18 18:06 KevinLamb