ACMESharp icon indicating copy to clipboard operation
ACMESharp copied to clipboard

Published 20 hours ago • verified publisher icon ebekker

Cloudflare handler fails when no DNS records are available

Open janpieterz opened this issue 7 years ago • 4 comments

The Cloudflare handler will hang until CloudFlare blocks the DNS queries because of too many requests.

My guess is that https://github.com/ebekker/ACMESharp/blob/master/ACMESharp/ACMESharp.Providers.CloudFlare/CloudFlareHelper.cs#L96 returns 0 total pages or something alike.

Don't have an empty domain lying around (anymore) to test and fix this, will happily take a look if someone is willing to lend me access to one or if I happen to get one.

janpieterz avatar May 24 '17 06:05 janpieterz

Can I ask, how did you discover this issue? If you don't have an empty domain, I assume you didn't run into it personally? Was it reported by someone else?

ebekker avatar Aug 02 '17 03:08 ebekker

Sure! We got a new domain and had to get it started, so encountered the issue but then had to quick fix (by adding 1 record) because we had to go live with the domain quick.

janpieterz avatar Aug 02 '17 08:08 janpieterz

I see, so your test case no longer exists.

Basically, I'm going to leave the ticket open for now until the next CF user encounters something similar so we can troubleshoot.

ebekker avatar Aug 02 '17 20:08 ebekker

Agreed! Any time I'll get a (new) domain under my control that I can empty out I'll jump into this too.

janpieterz avatar Aug 03 '17 09:08 janpieterz