ebean icon indicating copy to clipboard operation
ebean copied to clipboard

[Enhancement] Possibility for a Lettuce variant of "ebean-redis"?

Open mechite opened this issue 2 years ago • 7 comments

Personally I find Lettuce to be the modern client. Jedis brings in dependencies such as gson, org.json:json, but is also just not a very well made client, whereas both Lettuce and Redisson are arguably much better quality clients.

Proposed naming scheme could be any of the following:

  • Renaming ebean-redis:
    • ebean-jedis
    • ebean-lettuce
    • ebean-redisson
  • Suffix instead:
    • ebean-redis - aggregator/bundle
    • ebean-redis-jedis
    • ebean-redis-lettuce
    • ebean-redis-redisson

In any case, it should be trivial to at least support Lettuce so we have one high-quality implementation to target. I'm unsure what the correct abstraction for a connection would be to support both regular, cluster, etc connections, but I'm thinking instead of providing/injecting our own client connection (and having to deal with the complexity of this), there can instead be connection configuration and ebean connect to the server automatically, using cluster if needed depending on config etc.

mechite avatar Sep 24 '23 20:09 mechite

I also don't like jedis

SentryMan avatar Sep 24 '23 20:09 SentryMan

Personally I find Lettuce to be the modern client

Yeah, no problem with that. Are you going to build / contribute a ebean-lettuce module? Happy to have a look at that and rename things as appropriate when we have that etc.

rob-bygrave avatar Sep 25 '23 02:09 rob-bygrave

Personally I find Lettuce to be the modern client

Yeah, no problem with that. Are you going to build / contribute a ebean-lettuce module? Happy to have a look at that and rename things as appropriate when we have that etc.

I can absolutely do that (when I make the time) - I'll maintain it as a fork of this repository (and ebean-redis) and try to mirror the same functionality, will link here when we have that

mechite avatar Sep 25 '23 09:09 mechite

Cool. We can close this for the meantime and re-open when you get to it.

rbygrave avatar Nov 21 '23 09:11 rbygrave

We built one, please take a look if it's still of interest.

noboomu avatar May 09 '25 17:05 noboomu

Very nice. Would you like to contribute it and have it located in ebean's git repo?

rbygrave avatar May 14 '25 09:05 rbygrave

I would be honored if it passes your muster sir. I'll drop the JVM version 21 requirement shorlty!

noboomu avatar May 22 '25 05:05 noboomu