ebean
ebean copied to clipboard
ebean-orm
Bump mariadb-java-client to 3.0.7
Bumped mariadb-java-client version to 3.0.7 to see which tests may break (see #2782)
Given that all tests passed I would assume that the relevant code path was not taken by any of the tests? I'm not sure about your CI setup but there seems to be no coverage data to verify this?
relevant code path was not taken by any of the tests?
It's more that we have different github actions for the different databases and we don't run those database specific actions on each PR. So the PR's are run against H2 database.
Normally I can choose the MariaDB action and run that against a branch ... but it isn't seeing this PR branch. Hmmm.
Yeah, I can't run the action against the forked branch. I'll look to merge this in and then run using the MariaDB action and that should fail.
Background: From memory ebean is using that weird setting to get mysql jdbc driver to "stream" results rather than "pull all results into local buffer" and ebean does this for findEach, findStream, findIterate queries. There is also another "bit of a hack/limitation" we hit with mysql around firing secondary queries while streaming results so perhaps the mariadb driver also fixed that issue.