ebbit1q

Results 305 comments of ebbit1q

only the mainboard and sideboard are hashed, everything else is ignored

actually, adding the full decklist used by the player for the replay might be very useful for those cases where it's the only way to check if someone cheated like...

I thought of how I'd like to see that implemented and ticketed it https://github.com/Cockatrice/Cockatrice/issues/4661 it's out of scope here but would be cool to see

for proper context: cockatrice's ui classes include a retranslateUi() function that will set all of the visible text in the interface, this function is to be called in the constructor...

no, we should only offer to sort the view to the graveyard, not sort the graveyard itself

This is a simple oversight in implementation where probably because it is harder to do we didn't make the create all tokens action hidable

👍 seems good. I don't think the xml tag needs to be named conjure though, what it really does is make a non destroyable card, this might be useful for...

the location commands are handled is in the common server player, this is where the server/local game logic is and the getDestroyOnZoneChange property is interpreted.

this part is basically unchanged from the v3 parser, it could simply be added to the v3 parser as well without issue, I know for example mse's export code still...

future note: after this is merged https://github.com/Cockatrice/Cockatrice/wiki/Custom-Cards-&-Sets needs to be updated