ansible-role-bigbluebutton icon indicating copy to clipboard operation
ansible-role-bigbluebutton copied to clipboard

Added bbb_docker_python_version variable

Open simoncolincap opened this issue 1 year ago • 12 comments

Fixes https://github.com/ebbba-org/ansible-role-bigbluebutton/issues/371 by setting a specific version for the Docker Python package.

simoncolincap avatar Dec 12 '23 13:12 simoncolincap

Hmm something is up the full deployment test. Need to check that out.

BrutalBirdie avatar Dec 16 '23 16:12 BrutalBirdie

Having the same problem

cherbst avatar Dec 23 '23 13:12 cherbst

Same here, Nodes get thrown out of monitoring after running the role including the PR

GUFFMHRZ avatar Dec 28 '23 10:12 GUFFMHRZ

is it correct, that this PR merges into bbb/2.6? I have the same problem with bbb/2.7

berott avatar Dec 30 '23 14:12 berott

is it correct, that this PR merges into bbb/2.6? I have the same problem with bbb/2.7

Oh! Did not even notice that. Yes right, should actually be merged against the master branch. I have adjusted that.

BrutalBirdie avatar Dec 30 '23 18:12 BrutalBirdie

The full deployment test still fails: https://github.com/ebbba-org/ansible-role-bigbluebutton/actions/runs/7182177988/job/20047264408?pr=372#step:6:3932

I will check this out now.

BrutalBirdie avatar Dec 30 '23 18:12 BrutalBirdie

@cherbst and @GUFFMHRZ I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set? Because I just run with this PR diff applied with no issues.

BrutalBirdie avatar Dec 30 '23 18:12 BrutalBirdie

I use the following monitoring-configuration:

    bbb_monitoring_all_in_one_enable: true
    bbb_monitoring_all_in_one_grafana: false
    bbb_monitoring_all_in_one_prometheus: false
    bbb_monitoring_recordings_from_disk: false
    bbb_monitoring_external: true
    bbb_monitoring_htpasswd_user: "{{bbb_mon_user}}"
    bbb_monitoring_htpasswd: "{{bbb_mon_pass}}"
    bbb_monitoring_systemd_enable: false

Temporary I changed the docker-version manually (based on the information of this PR), after that it runs correctly:

- name: Install python docker packages
  pip:
    name:
      - docker==6.1.3
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"

berott avatar Dec 31 '23 12:12 berott

@cherbst and @GUFFMHRZ I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set? Because I just run with this PR diff applied with no issues.

Hi, we're running:

- name: Install python docker packages
  pip:
    name:
      - docker=={{ bbb_docker_python_version }}
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"
# https://pypi.org/project/docker/#history
bbb_docker_python_version: 6.1.3
# https://pypi.org/project/docker-compose/#history
bbb_docker_compose_version: 1.29.2

and

bbb_monitoring_all_in_one_enable: yes
bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_exporter_version: latest
bbb_monitoring_external: true

GUFFMHRZ avatar Dec 31 '23 13:12 GUFFMHRZ

Temporary I changed the docker-version manually (based on the information of this PR), after that it runs correctly:

- name: Install python docker packages
  pip:
    name:
      - docker==6.1.3
      - docker-compose=={{ bbb_docker_compose_version }}
    state: "{{ bbb_state }}"

This did not help us

GUFFMHRZ avatar Jan 01 '24 11:01 GUFFMHRZ

@cherbst and @GUFFMHRZ I assume you are using the:

bbb_monitoring_all_in_one_enable: true

Variable.

Are you also setting:

bbb_monitoring_all_in_one_grafana: false
bbb_monitoring_all_in_one_prometheus: false
bbb_monitoring_external: true

Or what do you people set? Because I just run with this PR diff applied with no issues.

What I meant to say was that this PR fixes the problem in #371, not that I have a problem with this PR. We have

bbb_monitoring_all_in_one_enable: true

and none of the other monitoring settings.

cherbst avatar Jan 02 '24 09:01 cherbst

Sorry for not doing anything here for so long. But now I finally hit this rock again :D

Came back to the issue and starting thinking. We should switch to community.docker.docker_compose_v2

Since it only needs:

Docker CLI with Docker compose plugin 2.18.0 or later

    PyYAML if [definition](https://docs.ansible.com/ansible/latest/collections/community/docker/docker_compose_v2_module.html#ansible-collections-community-docker-docker-compose-v2-module-parameter-definition) is used

and the pip package can be gone.

Thoughts?

EDIT: After looking at the old version, it has been marked as DEPRECATED anyway :) So I will close this PR and push a new one with the new changes.

BrutalBirdie avatar May 23 '24 14:05 BrutalBirdie