emeus icon indicating copy to clipboard operation
emeus copied to clipboard

unclear unref

Open matthiasclasen opened this issue 8 years ago • 0 comments

In the middle of simplex_solver_remove_constraint, I see:

no_columns: if (g_hash_table_lookup (solver->rows, marker) != NULL) simplex_solver_remove_row (solver, marker, TRUE); else variable_unref (marker);

But I can't find a corresponding ref that the unref would match up with.

And also, a few lines further down, I see:

      if (v != marker)
        simplex_solver_remove_column (solver, v);

Even if we had a reference, should we really be dropping it before this use of marker ?

matthiasclasen avatar Nov 04 '17 15:11 matthiasclasen