Emmanuele Bassi

Results 87 comments of Emmanuele Bassi

Then that's a pygobject and/or pycairo bug: - https://gitlab.gnome.org/GNOME/pygobject/-/issues - https://github.com/pygobject/pycairo/issues

That only really helps for properties and signal handlers, not for function arguments and return values, unless those arguments take a `GValue`.

@behdad Nothing has changed in the attribute checks at least since 2010. The warning seems to be coming from: ```xml ``` i.e. ```c /** * HB_CODEPOINT_INVALID: * * Unused #hb_codepoint_t...

The fact that the XML is so different is puzzling; @line72 are you trying to regenerate the GIR from the typelib and then compiling it back?

Correct. C strings should either be without annotation, to signal they are UTF-8 encoded; or should use a `filename` annotation, to signal that they are Unix paths, using whatever native...

It usually helps to specify *why* you need to change something. In this particular case: why is it necessary to update the version of the action?

Perfect, thank you for the explanation.

Thanks! I'll review this MR soon once I can properly test it.

Drive-by comment: the coding style is all over the place, and does not match the existing one. Please, use a style consistent with the rest of the file you're modifying.

Actually, the compiler warnings situation is not nice. We're currently using `warning_level=2` but: - we should really use `warning_level=3` - we should add more warnings to the Meson baseline xdg-desktop-portal-gtk...