Russell Harmon
Russell Harmon
Cleaned up most of them except for c61af39b454ab84478bb297ef0e85cc4753d3fdc, which will require some merge deconflicting to eliminate, so I left it. Let me know if you'd prefer I remove it. I...
According to the CI, this is the errors: ``` cmd/cmount/errors.go:1: File is not `goimports`-ed (goimports) // +build cmount cmd/mount/file.go:135: File is not `goimports`-ed (goimports) return true // keep going ```...
``` Error: cmd/all/all.go:15:2: //go:build comment without // +build comment ``` Fixed. I'll see about installing go 1.17 (I'm on 1.13) so I don't keep needing you to rerun the CI....
I installed go 1.17 and indeed, gofmt now reports warnings for most of the files in rclone (all those with `// +build` comments). ``` $ gofmt -l . | wc...
The Windows build failure doesn't seem right... ``` --- FAIL: TestDockerPluginMountTCP (0.53s) docker_test.go:386: Error Trace: docker_test.go:386 docker_test.go:409 Error: Received unexpected error: open C:\Users\RUNNER~1\AppData\Local\Temp\rclone4097017005\path1\txt: The system cannot find the file specified....
Given the one unstable test, I think this is ready for final review + merge.
I've fixed the lint error (odd that it didn't come up earlier), and rebased the changes against the latest HEAD. PTAL. Hopefully new issues won't have cropped up since merging.
Friendly ping here, looks like because this has been sitting for a while it needs some rebasing to merge successfully now. I'm happy to do that if you'd prefer, but...
Is there anything left for me to do here, or are we just waiting for @ncw to review?
@ncw friendly ping, are you still willing to pull in this change?