kicadStepUpMod icon indicating copy to clipboard operation
kicadStepUpMod copied to clipboard

Initial commit for translate WB

Open Kuzma30 opened this issue 3 years ago • 11 comments

Kuzma30 avatar Jul 23 '22 13:07 Kuzma30

ping @easyw

Kuzma30 avatar Jul 25 '22 17:07 Kuzma30

Anybody home and read this? Can I continue patch for localization or this is not interesting for author?

Kuzma30 avatar Aug 02 '22 14:08 Kuzma30

hi @Kuzma30 sorry for being late in replying you... yes this is a interesting feature... I have limitated access to web atm... I'm going to follow this PR amd its evolution you can ping me or PM at kicad.info forum ... I check it more frequently

easyw avatar Aug 12 '22 15:08 easyw

hi @Kuzma30 sorry for being late in replying you... yes this is a interesting feature... I have limitated access to web atm... I'm going to follow this PR amd its evolution you can ping me or PM at kicad.info forum ... I check it more frequently

You can merge this PR in current state.

Kuzma30 avatar Aug 24 '22 16:08 Kuzma30

@Kuzma30 I'm not used to add translations to a project... Does the '.ts' file need to be manually edited, pointing to the exact line number, or it is automatically generated? I see there is some wip also here... https://github.com/easyw/Manipulator/pull/11 Are these two PRs based on the same method?

easyw avatar Aug 31 '22 13:08 easyw

Ts file generated by Qt tools program. This link may be useful https://wiki.freecadweb.org/Translating_an_external_workbench

Kuzma30 avatar Aug 31 '22 14:08 Kuzma30

Hi @easyw. What is a reason do not merge translation support for your WB?)

Kuzma30 avatar Dec 13 '22 17:12 Kuzma30

@Kuzma30 sorry for delaying in reviewing this PR... I don't check often GH messages.

My issue with this PR is that I'm not familiar with the process in translation wbs.

If I understand it correctly, this PR is just a first step to start the translation process. Do you have a repository with a more advanced translation status of the wb? Then I would be more confident in merging it.

Thanks for working on this aspect, that I would like to be integrated in StepUp.

easyw avatar Jan 18 '23 08:01 easyw

@easyw Kuzma30 participated in improving the quality of FreeCAD's GUI translations. Several of his PRs with translation improvements have been merged in the past. He lives in Ukraine. Since Ukraine has been invaded he has not been able to be contacted.

From your conversation, it seems that the code was prepared by him and has been waiting to be merged for a year. I think there is nothing to wait further. :Wink:

kaktusus avatar Aug 26 '23 07:08 kaktusus

@easyw I have prepared some links for you. If you still have some doubts or feel deficient in knowledge these posts will certainly be helpful. :wink:

  • a good guide for the developer: https://github.com/FreeCAD/DevelopersHandbook/blob/master/technical/translation.md

  • as others are doing: https://github.com/shaise/FreeCAD_FastenersWB/blob/master/TRANSLATIONS.md https://github.com/shaise/FreeCAD_SheetMetal/blob/master/TRANSLATIONS.md https://github.com/dprojects/Woodworking/tree/master/translations

kaktusus avatar Aug 26 '23 09:08 kaktusus

any progress here ?

luzpaz avatar Nov 02 '23 14:11 luzpaz