kicad-3d-models-in-freecad icon indicating copy to clipboard operation
kicad-3d-models-in-freecad copied to clipboard

Published 20 hours ago • verified publisher icon easyw

remove duplicated function multiFuseObjs_wColors

Open tolot27 opened this issue 5 years ago • 3 comments

It looks like multiFuseObjs_wColors is duplicated at https://github.com/easyw/kicad-3d-models-in-freecad/blob/f2fe1731ecc88cb44da38f14bf6a1172e1a3d959/cadquery/FCAD_script_generator/_tools/cq_cad_tools.py#L260

tolot27 avatar Jan 02 '19 00:01 tolot27

Is there any reason why this PR was not merged? It seems quite a good idea to fix a duplicate function in the file.

Qbort avatar Jun 17 '20 11:06 Qbort

The endind of the two function is different.

I think only René @poeschlr can tell what is the intention here and remove duplicate things.

      # Remove the fusion itself
-    fusedObj = App.ActiveDocument.ActiveObject
-    SimpleCopy_wColors(fusedObj)
-    FreeCAD.ActiveDocument.removeObject(fusedObj.Name)
-    fused_obj = App.ActiveDocument.ActiveObject
+    App.getDocument(docName).removeObject("Fusion")
 
     return fused_obj

Franck78 avatar Sep 05 '20 12:09 Franck78

ping @poeschlr

Franck78 avatar Oct 07 '20 18:10 Franck78