see icon indicating copy to clipboard operation
see copied to clipboard

Add vdiffr snapshot tests for diagnostic plots (#236)

Open ANAMASGARD opened this issue 1 month ago • 3 comments

I've added 18 vdiffr tests that cover the main check_model() plots and their variations. These should catch any visual regressions in future updates.

Tests cover check_model(), check_normality(), check_outliers(), and check_homogeneity() with various themes, colors, and options. Also validates that the large dataset performance fix produces visually consistent output.

I followed the tutorial from https://indrajeetpatil.github.io/intro-to-snapshot-testing/ to learn how vdiffr works.

Contributes to #236

ANAMASGARD avatar Nov 09 '25 13:11 ANAMASGARD

Summary of Changes

Hello @ANAMASGARD, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness of the plotting functions by adding a suite of vdiffr snapshot tests. The primary goal is to catch any unintended visual changes in diagnostic plots early in the development cycle, ensuring a consistent user experience and reliable output. These tests cover a wide range of plot types and configurations, including how they render with different themes and custom color palettes, and specifically validates the visual output for large datasets.

Highlights

  • New Snapshot Tests: Introduced 18 new vdiffr snapshot tests to prevent visual regressions in diagnostic plots.
  • Comprehensive Plot Coverage: Tests cover check_model(), check_normality(), check_outliers(), and check_homogeneity() plots, including variations in themes, colors, and options.
  • Large Dataset Validation: Ensures visual consistency of plots when handling large datasets, validating performance fixes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 09 '25 13:11 gemini-code-assist[bot]

Code Quality Improvements

Implemented Gemini AI code review suggestions:

  • Added expect_doppelganger_with_seed() helper function

ANAMASGARD avatar Nov 09 '25 13:11 ANAMASGARD

Thanks a lot, let me review this PR!

strengejacke avatar Dec 01 '25 10:12 strengejacke