next-core icon indicating copy to clipboard operation
next-core copied to clipboard

Published 20 hours ago • verified publisher icon easyops-cn

fix(): use node 22

Open weareoutman opened this issue 1 year ago • 2 comments

依赖检查

组件之间的依赖声明，是微服务组件架构下的重要信息，请确保其正确性。

请勾选以下两组选项其中之一：

  • [x] 本次 MR 没有使用上游组件（例如框架、后台组件等）的较新版本提供的特性。

或者：

  • [ ] 本次 MR 使用了上游组件（例如框架、后台组件等）的较新版本提供的特性。
  • [ ] 在对应的文件中更新了该上游组件的依赖版本（或确认了当前声明的依赖版本已包含本次 MR 使用的新特性）。

提交信息检查

Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG，请检查工作内容与提交信息是否相符，并在以下每组选项中都依次确认。

破坏性变更是针对于下游使用者而言，可以通过本次改动对下游使用者的影响来识别变更类型：

  • 下游使用者不做任何改动，仍可以正常工作时，那么它属于普通变更。
  • 反之，下游使用者不做改动就无法正常工作时，那么它属于破坏性变更。

例如，构件修改了一个属性名，小产品 Storyboard 中需要使用新属性名才能工作，那么它就是破坏性变更。 又例如，构件还没有任何下游使用者，那么它的任何变更都是普通变更。

破坏性变更：

  • [ ] ⚠️ 本次 MR 包含破坏性变更的提交，请继续确认以下所有选项：
  • [ ] 没有更好的兼容方案，必须做破坏性变更。
  • [ ] 使用了 feat 作为提交类型。
  • [ ] 标注了 BREAKING CHANGE: 你的变更说明。
  • [ ] 同时更新了本仓库中所有下游使用者的调用。
  • [ ] 同时更新了本仓库中所有下游使用者对该子包的依赖为即将发布的 major 版本。
  • [ ] 同时为其它仓库的 Migrating 做好了准备，例如文档或批量改动的方法。
  • [ ] 手动验证过破坏性变更在 Migrate 后可以正常工作。
  • [ ] 破坏性变更所在的提交没有意外携带其它子包的改动。

新特性：

  • [ ] 本次 MR 包含新特性的提交，且该提交不带有破坏性变更，并使用了 feat 作为提交类型。
  • [ ] 给新特性添加了单元测试。
  • [ ] 手动验证过新特性可以正常工作。

问题修复：

  • [x] 本次 MR 包含问题修复的提交，且该提交不带有新特性或破坏性变更，并使用了 fix 作为提交类型。
  • [x] 给问题修复添加了单元测试。
  • [x] 手动验证过问题修复得到解决。

杂项工作：

即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动，例如修改注释、测试用例、开发文档等：

  • [ ] 本次 MR 包含杂项工作的提交，且该提交不带有问题修复、新特性或破坏性变更，并使用了 chore, docs, test 等作为提交类型。

Summary by CodeRabbit

  • 新特性

    • 更新了构建过程中使用的Node.js版本，从20.x升级到22.x，确保与最新版本的兼容性。

  • 依赖更新

    • 更新了package.json中的@types/node版本，从^20.16.2更改为^22.9.0。

  • 配置文件更新

    • 更新了.nvmrc文件中的Node.js版本，从20更改为22。

weareoutman avatar Nov 19 '24 07:11 weareoutman

Walkthrough

此次更改主要涉及多个工作流配置文件中Node.js版本的更新。所有相关文件的node-version均从20.x更新至22.x，影响到CI流程中的构建、测试及依赖管理等步骤。此外，.nvmrc文件中的Node.js版本也相应更新，而package.json中的@types/node依赖版本也进行了升级。packages/brick-container/build.config.js文件中的JSON模块导入语法也进行了调整，但未改变其他逻辑或控制流。

Changes

文件路径 更改摘要
.github/workflows/ci.yml 更新node-version从20.x至22.x，影响所有使用Node.js的CI作业。
.github/workflows/lerna-version.yml 更新node-version从20.x至22.x，影响Lerna版本命令的执行环境。
.github/workflows/update-docs-etc.yml 更新node-version从20.x至22.x，影响Node.js相关作业的执行环境。
.nvmrc 更新Node.js版本从20至22。
package.json 更新@types/node依赖版本从^20.16.2至^22.9.0。
packages/brick-container/build.config.js 更新JSON模块导入语法，从assert语法更改为with语法。

[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/brick-container/build.config.js

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@next-core/eslint-config-next" to extend from. Please check that the name of the config is correct.

The config "@next-core/eslint-config-next" was referenced from the config file in "/.eslintrc".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Nov 19 '24 07:11 coderabbitai[bot]

next-core    Run #10790

Run Properties:  status check passed Passed #10790  •  git commit b24cb51bde ℹ️: Merge 5d3a7c0b957e9beb4f1bcf1175a99f6612ae1975 into 62daee3c6ea1f6d0767c3516b72f...
Project next-core
Branch Review steve/v3-node-22
Run status status check passed Passed #10790
Run duration 00m 23s
Commit git commit b24cb51bde ℹ️: Merge 5d3a7c0b957e9beb4f1bcf1175a99f6612ae1975 into 62daee3c6ea1f6d0767c3516b72f...
Committer Shenwei Wang
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 16
View all changes introduced in this branch ↗︎

cypress[bot] avatar Nov 19 '24 07:11 cypress[bot]