easybuild-framework icon indicating copy to clipboard operation
easybuild-framework copied to clipboard

Added possibility to call `amend/try-amend` multiple times from easystack

Open Crivella opened this issue 1 year ago • 3 comments

Related to:

  • #4643

This change checks if the option in the easystack belongs to a list of options that allows to be defined multiple times (could be defined in a more generic location) and instead of setting it's value as a list, will set it multiple times to the cli arguments.

Possible breaking change:

  • Any currently existing easystack that makes use of a pattern like
      options:
        - try-amend:
          - opt=1
          - 2
          - 3
    
    in order to set --try-amend=opt=1,2,3 would not work anymore

Crivella avatar Oct 04 '24 14:10 Crivella

Thank you for working on this! I just tested and can verify that it works exactly as desired for our use case. If this does get merged in as is, I wrote up a documentation PR (that I am happy to edit as desired):

  • https://github.com/easybuilders/easybuild-docs/pull/281

cgross95 avatar Oct 04 '24 15:10 cgross95

LGTM but maybe @boegel wants to take a look as there is a (very unlikely to be used) breaking change in here (as mentioned in #4667 (comment))

It's OK I think, especially since easystack files are (still) an experimental feature currently...

That said, it's high time we remove the experimental tag for easystack files, definitely for EasyBuild 5.0...

boegel avatar Oct 04 '24 19:10 boegel

@boegel does this still need work or can it be merged now?

bartoldeman avatar Oct 23 '24 16:10 bartoldeman