easybuild-framework icon indicating copy to clipboard operation
easybuild-framework copied to clipboard

Fix the checksum type check

Open Flamefire opened this issue 2 years ago • 3 comments

The None case was missed and due to the unrestricted tuple elem_type it may return valid for actually invalid entries. So restrict that beeing overly cautious so it may wrongly return invalid.
But in that case the conversion function will be called which can do more elaborate verification.

Add test checking for None in checksums.

Extracted from #4159, see https://github.com/easybuilders/easybuild-framework/pull/4159#issuecomment-1373429332

Also required for #4142 as the check now correctly handles a None value in the dict

Requires resolution of

  • [ ] https://github.com/easybuilders/easybuild-docs/pull/104

Flamefire avatar Jan 06 '23 10:01 Flamefire

Converted to draft to first specify how checksums especially "None" should work

Flamefire avatar Jan 20 '23 12:01 Flamefire

Specifying as ready as the inability to specify alternate checksums in a dict blocks e.g. https://github.com/easybuilders/easybuild-easyconfigs/pull/19231

Flamefire avatar Nov 15 '23 19:11 Flamefire

Can this (and https://github.com/easybuilders/easybuild-docs/pull/104) be addressed? It is also a dependency of https://github.com/easybuilders/easybuild-framework/pull/4159

Flamefire avatar Jun 20 '24 14:06 Flamefire

Closed for https://github.com/easybuilders/easybuild-framework/pull/4578

Flamefire avatar Dec 18 '24 15:12 Flamefire