easybuild-easyconfigs icon indicating copy to clipboard operation
easybuild-easyconfigs copied to clipboard

{bio}[system/system] RFDiffusion-models v1.1.0, RFDiffusion-schedules v1.1.0

Open smoors opened this issue 2 years ago • 1 comments

(created using eb --new-pr)

depends on:

  • https://github.com/easybuilders/easybuild-easyblocks/pull/3246
  • https://github.com/easybuilders/easybuild-framework/pull/4474

cfr. https://github.com/easybuilders/easybuild-easyconfigs/pull/18359 @ThomasHoffmann77

smoors avatar Mar 03 '24 13:03 smoors

@smoors Could you please rename to RFdiffusion to be consistent with #18359 naming?

ThomasHoffmann77 avatar Mar 11 '24 16:03 ThomasHoffmann77

Test report by @smoors Using easyblocks from PR(s) https://github.com/easybuilders/easybuild-easyblocks/pull/3246 SUCCESS Build succeeded for 2 out of 2 (2 easyconfigs in total) node601.hydra.os - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, AMD EPYC 9384X 32-Core Processor, Python 3.9.20 See https://gist.github.com/smoors/26855bb33a16c522f00f2bda16044711 for a full test report.

smoors avatar May 08 '25 20:05 smoors

Test report by @smoors Using easyblocks from PR(s) https://github.com/easybuilders/easybuild-easyblocks/pull/3246 SUCCESS Build succeeded for 2 out of 2 (2 easyconfigs in total) node600.hydra.os - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, AMD EPYC 9384X 32-Core Processor, Python 3.9.20 See https://gist.github.com/smoors/0f0cc04633c4c29b5b68ad26fbca2724 for a full test report.

smoors avatar May 09 '25 07:05 smoors

Note for anyone else testing this: the five files in RFdiffusion-schedules/1.1.0 are identical, but with different names. This means that the object store method used deduplicates this to one file in the object store with five symlinks to it.

branfosj avatar May 09 '25 08:05 branfosj

I suspect adding to https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/test/easyconfigs/easyconfigs.py#L1021 will fix

======================================================================
FAIL: test_downloadable_or_instructions (test.easyconfigs.easyconfigs.EasyConfigTest.test_downloadable_or_instructions)
Make sure the sources are downloadable or there are instructions for how to download them.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1045, in test_downloadable_or_instructions
    self.fail(error_msg % (len(problem_ecs), ', '.join(problem_ecs)))
AssertionError: 2 easyconfigs found without defined sources or download_instructions: /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/RFdiffusion-models/RFdiffusion-models-1.1.0.eb, /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/r/RFdiffusion-schedules/RFdiffusion-schedules-1.1.0.eb

https://github.com/easybuilders/easybuild-framework/pull/4874 to fix

======================================================================
FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest.test_pr_sha256_checksums)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1182, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: False is not true : No checksum issues:
Checksums missing for one or more sources/patches in RFdiffusion-models-1.1.0.eb: found 0 sources + 0 patches vs 9 checksums
Checksums missing for one or more sources/patches in RFdiffusion-schedules-1.1.0.eb: found 0 sources + 0 patches vs 1 checksums

branfosj avatar May 09 '25 09:05 branfosj

@boegelbot please test @ jsc-zen3

smoors avatar May 09 '25 13:05 smoors

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20019 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20019 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6321

Test results coming soon (I hope)...

- notification for comment with ID 2866510303 processed

Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).

boegelbot avatar May 09 '25 13:05 boegelbot

Test report by @boegelbot SUCCESS Build succeeded for 2 out of 2 (2 easyconfigs in total) jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21 See https://gist.github.com/boegelbot/9d66fef8a11f258de2719820eafcb944 for a full test report.

boegelbot avatar May 09 '25 13:05 boegelbot

Going in, thanks @smoors!

jfgrimm avatar May 09 '25 13:05 jfgrimm