easybuild-easyconfigs icon indicating copy to clipboard operation
easybuild-easyconfigs copied to clipboard

{devel}[system/system] ant v1.10.12

Open SimonPinches opened this issue 2 years ago • 5 comments

(created using eb --new-pr)

SimonPinches avatar Aug 11 '22 17:08 SimonPinches

I did wonder whether this EB file should just be named ant-1.10.12.eb and not have any Java dependency since then there would be no need for ant-1.10.12-Java-17.eb?

SimonPinches avatar Aug 11 '22 17:08 SimonPinches

I did wonder whether this EB file should just be named ant-1.10.12.eb and not have any Java dependency since then there would be no need for ant-1.10.12-Java-17.eb?

I don't understand what you mean at all here. It does definitely depend on Java? and I see no connection as to how ant-1.10.12-Java-17.eb makes any difference one way or another.

Micket avatar Aug 12 '22 12:08 Micket

What I meant is that it does not depend upon a specific version of Java for installation (it's just a PackedBinary). If this module were just called ant-1.10.12.eb then the user could select the version of Java without the need for separate ant-1.10.12-Java-XX.eb modules.

SimonPinches avatar Aug 12 '22 13:08 SimonPinches

Right, i see where you are coming from. The same applies to a lot of java apps. Skipping the dep means that

  1. it won't work for a user that just module load ant, not terrible, something we've tried to avoid elsewhere
  2. also means we can't do sanity checks of installs. E.g. had ant been introduced now, we've probably asked for a sanity_check_command for ant -h

Benefit is not having to double up on these, though in practice, we'll likely just have everything Java-11 as much as possible, until we switch to having Java-17 as much as possible, so..

I'd like other maintainers opinion on this.

Micket avatar Aug 12 '22 17:08 Micket

I know my users will grumble that that the 'software is broken' if no Java is loaded by ant. I am wondering if there is a solution using multideps.

branfosj avatar Aug 17 '22 08:08 branfosj

@boegelbot please test @ generoso

boegel avatar Aug 22 '22 17:08 boegel

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16034 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16034 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9037

Test results coming soon (I hope)...

- notification for comment with ID 1222726240 processed

Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).

boegelbot avatar Aug 22 '22 18:08 boegelbot

Test report by @boegelbot SUCCESS Build succeeded for 1 out of 1 (1 easyconfigs in total) cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/b3edee6c76a1eecb61c71cb52d07c6bf for a full test report.

boegelbot avatar Aug 22 '22 18:08 boegelbot

Test report by @boegel SUCCESS Build succeeded for 1 out of 1 (1 easyconfigs in total) node3107.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8 See https://gist.github.com/3ad730a96afd81c34e9357bbccc507d2 for a full test report.

boegel avatar Aug 22 '22 18:08 boegel

Going in, thanks @SimonPinches!

boegel avatar Aug 22 '22 18:08 boegel