easybuild-easyconfigs icon indicating copy to clipboard operation
easybuild-easyconfigs copied to clipboard

Published 20 hours ago • verified publisher icon easybuilders

{devel}[GCCcore/10.2.0,GCCcore/11.2.0] Qt6 v6.2.3, PySide6 v6.2.3 w/ Python 3.8.6 + 3.9.6

Open kosl opened this issue 2 years ago • 13 comments

(created using eb --new-pr)

kosl avatar Mar 08 '22 21:03 kosl

@kosl I see you the CI is complaining about style issues. Of course you can push new commits, and have the CI check if that resolves the style issues. However, that means you have to wait for the CI to trigger and wait for the result. It's generally much faster to try it yourself by running eb --check-style <easyconfig>, fix the errors until that command is happy, and then commit them.

In this case, I think most style issues would be resolved if you remove all commented items, which I guess you were planning on doing at some point anyway :)

casparvl avatar Mar 09 '22 17:03 casparvl

Thank you @casparvl for taking care of the checks. This PR might not be complete at this point but it is a start for many of us. l can refine dependencies with 2022a toolchains when available.

kosl avatar Mar 10 '22 10:03 kosl

@boegelbot please test @ generoso

kosl avatar Mar 12 '22 18:03 kosl

@kosl: I noticed your comment, but I only dance when @akesandgren or @bartoldeman or @bedroge or @boegel or @branfosj or @casparvl or @jfgrimm or @lexming or @Micket or @migueldiascosta or @ocaisa or @SebastianAchilles or @smoors or @verdurin or @robert-mijakovic tells me (for now), I'm sorry...

- notification for comment with ID 1065943345 processed

Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).

boegelbot avatar Mar 12 '22 19:03 boegelbot

@boegelbot please test @ generoso

boegel avatar Mar 13 '22 09:03 boegel

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15096 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15096 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8272

Test results coming soon (I hope)...

- notification for comment with ID 1066056965 processed

Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).

boegelbot avatar Mar 13 '22 09:03 boegelbot

Test report by @boegelbot FAILED Build succeeded for 0 out of 4 (4 easyconfigs in total) cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/ce4d4671ff902264fdd4a424bb5595dd for a full test report.

boegelbot avatar Mar 13 '22 09:03 boegelbot

@boegelbot please test @ generoso

casparvl avatar Mar 13 '22 20:03 casparvl

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=15096 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15096 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8276

Test results coming soon (I hope)...

- notification for comment with ID 1066175783 processed

Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).

boegelbot avatar Mar 13 '22 20:03 boegelbot

Test report by @boegelbot FAILED Build succeeded for 0 out of 4 (4 easyconfigs in total) cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/5a25877cb84f647572cc6ee3ba2c0ab2 for a full test report.

boegelbot avatar Mar 13 '22 20:03 boegelbot

@kosl does this PR build for you locally? It probably only succeeds because it is picking up on various system libraries.

I compared your EasyConfig to the one for Qt5-5.12.2-GCCcore-11.2.0. I see you commented most dependencies. Although it's good to check if the same dependencies indeed still apply to Qt6, I think in large part they will. As you can see in the gist of the boegelbot build, it fails to find many optional libraries. Typically, it is good practice to include those in your EasyConfig for two reasons.

  1. It enables as many optional features as possible, which is good, since we don't know in advance which features our users would like to use.

  2. It prevents system versions of those libraries being picked up & linked in. Picking up on system libraries breaks reproducibility of building an EasyConfig between multiple system, since each system might have different versions of, say, Harfbuzz. This could result in an EasyConfig working on one system, but not on another, due to a version issue. In fact, looking at the gist, this is probably happening to PCRE2 since the configure suggest a system PCRE2 was found, but the PCRE2 dependency is still commented out in the EasyConfig. I.e. this would make the build link to a system PCRE2, rather than the PCRE2 from EasyBuild.

I'd suggest to go through the list of libraries from the Qt5 EasyConfig and check the gist to see if Qt6 is still looking for them. If it is, I'd suggest to keep including them as dependencies.

Btw, I think your error comes from the fact that you commented out libGLU, which is the OpenGL Utility Library. I'm not 100% sure, but I think if you include it again in the list of dependencies, the build might work on our Generoso test infrastructure.

casparvl avatar Mar 13 '22 21:03 casparvl

Dependencies are back now and it should build. The problem is with CMake that was not built with zstd support. I have found configurable workaround for that.

kosl avatar Mar 14 '22 00:03 kosl

LGTM

kosl avatar Mar 15 '22 08:03 kosl

closing this since GCC/10.2.0 is deprecated, see https://docs.easybuild.io/policies/toolchains

see also:

  • #18683

boegel avatar Jan 14 '24 09:01 boegel