easybuild-easyblocks icon indicating copy to clipboard operation
easybuild-easyblocks copied to clipboard

Explicitely mention that the PyTorch easyblock needs updating when failing for this reason

Open Flamefire opened this issue 1 year ago • 1 comments
trafficstars

(created using eb --new-pr)

See https://github.com/easybuilders/easybuild-easyconfigs/pull/19666#issuecomment-1991295933 for the motivation

Flamefire avatar Mar 13 '24 10:03 Flamefire

@casparvl I updated the EasyBlock after the discussion at https://github.com/easybuilders/easybuild-easyblocks/pull/3255#discussion_r1524517112

I also noticed and fixed 2 things:

  • If we can't count failures we only failed if we counted ANY failure
  • We can't count failures if a test aborted but the previous iteration showed a message that the EasyBlock needed updating

I moved the detection of "uncounted suites" into the parser function such that we can test it (manually).

Flamefire avatar May 14 '24 15:05 Flamefire