easybuild-easyblocks icon indicating copy to clipboard operation
easybuild-easyblocks copied to clipboard

enhance `CMakeMake` easyblock to check whether correct Python installation was picked up by `cmake`

Open MartinsNadia opened this issue 1 year ago • 5 comments

Sanity check to verify if Cmake apply the new policy CMP0094

MartinsNadia avatar Feb 27 '24 11:02 MartinsNadia

@boegelbot please test @ generoso EB_ARGS="--installpath /tmp/pr3233 FlexiBLAS-3.3.1-GCC-12.3.0.eb SPAdes-3.15.4-GCC-12.3.0.eb Doxygen-1.9.7-GCCcore-12.3.0.eb poppler-23.09.0-GCC-12.3.0.eb"

boegel avatar Jun 25 '24 07:06 boegel

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=3233 EB_ARGS="--installpath /tmp/pr3233 FlexiBLAS-3.3.1-GCC-12.3.0.eb SPAdes-3.15.4-GCC-12.3.0.eb Doxygen-1.9.7-GCCcore-12.3.0.eb poppler-23.09.0-GCC-12.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks /opt/software/slurm/bin/sbatch --job-name test_PR_3233 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13805

Test results coming soon (I hope)...

- notification for comment with ID 2188166362 processed

Message to humans: this is just bookkeeping information for me, it is of no use to you (unless you think I have a bug, which I don't).

boegelbot avatar Jun 25 '24 07:06 boegelbot

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS FlexiBLAS-3.3.1-GCC-12.3.0.eb
  • SUCCESS SPAdes-3.15.4-GCC-12.3.0.eb
  • SUCCESS Doxygen-1.9.7-GCCcore-12.3.0.eb
  • SUCCESS poppler-23.09.0-GCC-12.3.0.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total) cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/boegelbot/65f7160953f1af9e1a9f587844f085be for a full test report.

boegelbot avatar Jun 25 '24 07:06 boegelbot

I added https://github.com/MartinsNadia/easybuild-easyblocks/pull/3 to get this done fast. It addresses the review and handles the "FindPython" (w/o version number) case.

Flamefire avatar Jun 25 '24 09:06 Flamefire

@MartinsNadia ping on reviewing/merging https://github.com/MartinsNadia/easybuild-easyblocks/pull/3 to update this PR?

boegel avatar Jul 03 '24 14:07 boegel

As @bedroge retargeted this to 5.x which creates difficult conflicts due to the considerable changes during review I created #3399 combining those 15 commits into 2

Flamefire avatar Jul 31 '24 07:07 Flamefire