easybuild-easyblocks icon indicating copy to clipboard operation
easybuild-easyblocks copied to clipboard

Inconsistent license variable naming

Open Micket opened this issue 1 year ago • 1 comments
trafficstars

We currently have a wide selection of license variable names in use. Grepping through the easyblocks we find for example:

LM_LICENSE_FILE
INTEL_LICENSE_FILE
ABAQUSLM_LICENSE_FILE
EB_MATLAB_LICENSE_SERVER
LMCOMSOL_LICENSE_FILE

so, it's either

  • LM_xxx
  • NAME_xxx
  • NAMELM_xxx
  • LMNAME_xxx
  • EB_NAME_xxx

I was going to suggest to stick to just one pattern:

EB_NAME_LICENSE_FILE
EB_NAME_LICENSE_SERVER
EB_NAME_LICENSE_PORT

Micket avatar Nov 29 '23 17:11 Micket

Doesn't really need to wait for 5.0 i guess, I'll just change COMSOL to use this syntax to reduce the variations a bit as a start. #3044

Micket avatar Nov 29 '23 17:11 Micket