easybuild-easyblocks icon indicating copy to clipboard operation
easybuild-easyblocks copied to clipboard

Published 20 hours ago • verified publisher icon easybuilders

New EasyBlocks for Spparks and Stitch

Open Mooon opened this issue 2 years ago • 4 comments

(created using eb --new-pr)

  • [ ] https://github.com/easybuilders/easybuild-easyconfigs/pull/18049
  • [ ] https://github.com/easybuilders/easybuild-easyconfigs/pull/18050

Mooon avatar Jun 06 '23 11:06 Mooon

@Mooon Both easyblocks are not small, so maybe it would help to have separate PRs for them, to easy to review/testing process. Unless there's a reason they're bundled together?

cc @casparvl

boegel avatar Jun 07 '23 14:06 boegel

@boegel I did an single PR for both easyblocks because the two softwares are linked together: up to date the Stitch library is developed for use with the SPPARKS software. But I can also separate them into two PRs if it makes it easier to review/testing

Mooon avatar Jun 07 '23 14:06 Mooon

@boegel I did an single PR for both easyblocks because the two softwares are linked together: up to date the Stitch library is developed for use with the SPPARKS software. But I can also separate them into two PRs if it makes it easier to review/testing

@Mooon No need for two separate PRs, but looking into the suggested changes would be nice.

boegel avatar Dec 06 '23 10:12 boegel

Hi @boegel @jfgrimm, I modified the scripts according to the received feedback. Please let me know if any further action is needed from my side to review this pr.

Mooon avatar Apr 17 '24 12:04 Mooon