easybuild-easyblocks icon indicating copy to clipboard operation
easybuild-easyblocks copied to clipboard

Update IPP easyblock for versions > 2021

Open agemuend opened this issue 2 years ago • 8 comments
trafficstars

(created using eb --new-pr)

agemuend avatar Mar 20 '23 14:03 agemuend

@agemuend: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyblocks/actions/runs/4469939787 Output from first failing test suite run:

ERROR: test_easyblock__home_runner_work_easybuild-easyblocks_easybuild-easyblocks_easybuild_easyblocks_i_ipp (test.easyblocks.module.ModuleOnlyTest)
Test for using --module-only with easyblock /home/runner/work/easybuild-easyblocks/easybuild-easyblocks/easybuild/easyblocks/i/ipp.py
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyblocks/module.py", line 404, in innertest
    template_module_only_test(self, easyblock, **kwargs)
  File "test/easyblocks/module.py", line 363, in template_module_only_test
    app.run_all_steps(run_test_cases=False)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyblock.py", line 4094, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyblock.py", line 3929, in run_step
    step_method(self)()
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyblock.py", line 3701, in make_module_step
    txt += self.make_module_req()
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyblock.py", line 1529, in make_module_req
    requirements = self.make_module_req_guess()
  File "/tmp/runner/c85881c26d666fcdff34b495d2e9545faa4c38e1/lib/python2.7/site-packages/easybuild/easyblocks/i/ipp.py", line 154, in make_module_req_guess
    'LD_LIBRARY_PATH': lib_path,
UnboundLocalError: local variable 'lib_path' referenced before assignment

----------------------------------------------------------------------
Log available at /tmp/eb-Fc3fdr/eb-54Ewzg/eb-b6jAWH/eb-53PX_1/easybuild-easyblocks-tests-V4OCwi.log
Ran 580 tests in 64.760s

FAILED (errors=1)
ERROR: Not all tests were successful.

bleep, bloop, I'm just a bot (boegelbot v20200716.01) Please talk to my owner @boegel if you notice me acting stupid), or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

boegelbot avatar Mar 20 '23 15:03 boegelbot

Test report by @akesandgren

Overview of tested easyconfigs (in order)

  • FAIL (build issue) ipp-2017.1.132.eb (partial log available at https://gist.github.com/akesandgren/a3ec32af9b8b85ad1f36dc2528703c64)

Build succeeded for 0 out of 1 (1 easyconfigs in total) b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10 See https://gist.github.com/akesandgren/2d271eaf7876e9d7150449b730f8701a for a full test report.

akesandgren avatar Sep 13 '23 14:09 akesandgren

As you can see, this breaks installation of older ipp versions.

akesandgren avatar Sep 13 '23 14:09 akesandgren

As you can see, this breaks installation of older ipp versions.

Mhm, thats interesting. The error is "directory already exists", but my patch actually introduces the suppression of making the installdir, because I thought it was newer installers that had problems with this. Does the 2017 version actually work before the patch?

agemuend avatar Sep 14 '23 07:09 agemuend

Yes it works before this PR. See my fix for the problem above.

akesandgren avatar Sep 14 '23 08:09 akesandgren

Yes it works before this PR. See my fix for the problem above.

Sorry, where exactly?

agemuend avatar Sep 14 '23 08:09 agemuend

Sorry, I managed to forget to click send the review.

akesandgren avatar Sep 14 '23 08:09 akesandgren

@agemuend ping

akesandgren avatar Sep 29 '23 05:09 akesandgren