easybuild-easyblocks
easybuild-easyblocks copied to clipboard
PythonPackage easyblock: modulename should be a first-class parameter, not under the options parameter
Currently to set the python module name to test in the sanity check the syntax is: "options={'modulename':'newname'}". The request is to change it to simply "modulename='newname'".
There should also be a more intuitive (and documented...) way of skipping the import check than setting modulename to False...
Note that for extensions it is already fine:
exts_list = [
('hydra-colorlog', '1.2.0', {
'sanity_pip_check': False,
'modulename': 'hydra',
'checksums': ['d44f85008fabd2448c7e3b496c31b44d7610560f6fff74f3673afaa949870899'],
}),
]
It doesn't get better there. So the requested change only applies to "root" PythonPackage. It looks like it is the only entry used from "self.options" so it indeed makes sense and I guess for extensions that would just work.
There should also be a more intuitive (and documented...) way of skipping the
importcheck than settingmodulenametoFalse...
That is only done for extensions isn't it? We should do it for PythonPackage too. Also note that "skipping the import check" also means that --skip won't work. So IMO we should just better document the behavior as I think modulename: False is clear enough for the only valid use case I can imagine: There is no package which could be imported.