easybuild-easyblocks icon indicating copy to clipboard operation
easybuild-easyblocks copied to clipboard

Published 20 hours ago • verified publisher icon easybuilders

add easyblock for RELION

Open lexming opened this issue 4 years ago • 5 comments

Depends on ~~#2280~~ and ~~#2302~~

Easyconfig in https://github.com/easybuilders/easybuild-easyconfigs/pull/10965

lexming avatar Dec 09 '20 09:12 lexming

@lexming it seems https://github.com/easybuilders/easybuild-easyblocks/pull/2280 was not enough, there's a similar code block in test/easyblocks/module.py

migueldiascosta avatar Dec 15 '20 07:12 migueldiascosta

@migueldiascosta fix for those tests in https://github.com/easybuilders/easybuild-easyblocks/pull/2302

lexming avatar Jan 06 '21 09:01 lexming

Successful test report in https://github.com/easybuilders/easybuild-easyconfigs/pull/10965#issuecomment-755300982

lexming avatar Jan 06 '21 13:01 lexming

It might be useful to split out the part concerning batch/queue systems (i.e. Slurm/Torque/LSF(?)) and their particulars to its own easyblock for use by others that might want to use it. I don't know what the EB framework uses for when it uses jobs to build things (I've always just built on the login nodes), but it might be able to use it too. Just a thought.

JackPerdue avatar Jan 07 '21 00:01 JackPerdue

Two other quick thoughts (although maybe best for a later update):

  • ALTCPU=ON should only be enabled when TBB is in the dependency chain, maybe it's worth detecting this (although I note the corresponding easyconfig does have this).
  • MKLFFT=ON maybe should be added when MKL is detected.

dithwick avatar Jan 07 '21 09:01 dithwick