easybuild-easyblocks icon indicating copy to clipboard operation
easybuild-easyblocks copied to clipboard

Published 20 hours ago • verified publisher icon easybuilders

Use of deprecated CMake options for Kokkos in LAMMPS easyblock

Open ocaisa opened this issue 4 years ago • 4 comments

Recent versions of LAMMPS (at least version 2Jun20) enforces camel casing for the Kokkos options (e.g., -DKokkos_ENABLE_CUDA=yes). Hopefully this naming was already supported in previous versions so we don't have to introduce version-related conditionals (which is tedious with LAMMPS versioning)

ocaisa avatar Jun 03 '20 13:06 ocaisa

Perhaps we need to have a convert_lammps_version_to_sane_version function to apply in init so we can use LooseVersion checks later on?

akesandgren avatar Jun 03 '20 14:06 akesandgren

@ocaisa fixed by #2208, right?

boegel avatar Oct 25 '20 21:10 boegel

Yes indeedy

ocaisa avatar Oct 25 '20 21:10 ocaisa

reopening this, since the fix from #2208 was reverted in #2211

boegel avatar Oct 28 '20 18:10 boegel