node-stomp-client icon indicating copy to clipboard operation
node-stomp-client copied to clipboard

add accept-version header to CONNECT frame when using version > 1.0

Open ellyxc opened this issue 8 years ago • 2 comments

Based on STOMP 1.1 specs (https://stomp.github.io/stomp-specification-1.1.html#Protocol_Negotiation):

From STOMP 1.1 and onwards, the CONNECT frame MUST include the accept-version header. It SHOULD be set to a comma separated list of incrementing STOMP protocol versions that the client supports. If the accept-version header is missing, it means that the client only supports version 1.0 of the protocol.

this PR does not introduce protocol negotiation

ellyxc avatar Apr 19 '17 05:04 ellyxc

@ellyxc , it seems this repo has been abandoned: did you make it work with STOMP 1.1 with your patch?

lmorandini avatar Jul 25 '19 01:07 lmorandini

@lmorandini yes, i did make it work. However we are deprecating stomp in our application as well.

ellyxc avatar Aug 01 '19 12:08 ellyxc