Visibility_range reverted to visibility in Version 0.38

[ashimgiyanani]

Describe the bug It seems that you have changed back to parameter visibility from visibility_range, without mentioning it in the changelog.

To Reproduce using latest version in Conda (0.38)

request = DwdObservationRequest(
    parameter= [
        "visibility_range",
    ],
    period = "recent",
    resolution="hourly",
    start_date=(data.tstart + dt.timedelta(minutes = 0)).strftime("%Y-%m-%d %H:%M"),
    end_date = data.tend.strftime("%Y-%m-%d %H:%M"),
    ).filter_by_station_id(station_id=(701))

Expected behavior That the python variable request has data, such that the import is successful.

Screenshots

Desktop (please complete the following information):

• OS: Windows
• Python-Version 3.9

Additional context changing the parameter value to "visbility" makes the script work and import data

[amotl]

Dear Ashim,

thank you very much for writing in and reporting a potential regression. We promise to get better with mentioning potentially breaking changes in the changelog.

On the very topic of parameter (re-)naming, @gutzbenj may respond to your question. By conducting a quick search, I can only spot #598 on that matter, where VISIBILITY was renamed to VISIBILITY_RANGE in Wetterdienst 0.29.0.

May I ask which version of Wetterdienst you have been using before upgrading? When looking at the current state, it looks like Wetterdienst 0.41.0 is the most recent version. Why would Conda be so much behind?

With kind regards, Andreas.

[kmuehlbauer]

Conda-Forge is behind because the single maintainer over there (@kmuehlbauer) does not have the bandwidth to follow new versions as they come out.

Interested people are invited to enlist as maintainers of the conda recipe https://github.com/conda-forge/wetterdienst-feedstock.

[amotl]

When looking at the current state, it looks like Wetterdienst 0.41.0 is the most recent version. Why would Conda be so much behind?

Ah, right. The feedstock repository needs some pull requests to be merged, see https://github.com/conda-forge/wetterdienst-feedstock/pulls.

[amotl]

Ha. We answered at the same time. Hey Kai. How would we proceed on that? Just add our GitHub handles to the CODEOWNERS file?

[kmuehlbauer]

Hang on a minute, there is a bot command. I'll check.

[kmuehlbauer]

@amotl @gutzbenj You should be able to work on the wetterdienst-feedstock now.

[amotl]

Thank you Kai. I've just created https://github.com/conda-forge/wetterdienst-feedstock/issues/53 in order to have a quick conversation to get us on board over there.

[ashimgiyanani]

Dear Andreas,

Thank you for the prompt reply. 

#598 seems to be the right time around which the visibility parameter was changed to visibility_range. The version at which, it works with visibility_range is 0.32.3 (on one of my PCs). Mit freundlichen GrüßenAshim Giyanani

On Monday, August 1, 2022 at 06:39:27 PM GMT+2, Andreas Motl ***@***.***> wrote:  

Dear Ashim,

thank you very much for writing in and reporting this regression. We promise to get better with mentioning potentially breaking changes in the changelog.

On the very topic of parameter naming, @gutzbenj may respond to your question. By conducting a quick search, I can only spot #598 on that matter.

May I ask which version of Wetterdienst you have been using before upgrading? When looking at the current state, it looks like Wetterdienst 0.41.0 is the most recent version. Why would Conda be so much behind?

With kind regards, Andreas.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

[gutzbenj]

Dear all, I think after updating the conda version of wetterdienst this issue can be closed.

Cheers Benjamin

[ashimgiyanani]

@amotl @kmuehlbauer @gutzbenj : Thank you for the update and I will run a feasibility check on Monday and report the status of the conda update.