shapedrawer icon indicating copy to clipboard operation
shapedrawer copied to clipboard

add polygon with offset methods, add drawing polygons as wireframe

Open judos opened this issue 2 years ago • 2 comments

  • add polygon methods with offset (x/y). This allows to reuse existing vertices arrays instead of recalculating them for every draw call.
  • add polygonWireframe method to draw the outline of a polygon useful for debugging manually created polygons.

judos avatar Sep 07 '22 22:09 judos

Hey thanks for the PR - I've tested it and have a couple of changes locally I'd like to add - what's the best way to do this? I can either push a commit to your fork somehow, or just make the commit in my repo after merging the PR.

Basically just using your added polygon method and calling polygon(vertices, triangles, trianglesCount, 0, 0) instead of duplicating the methods, and renaming and moving the wireframe method around a bit.

earlygrey avatar Sep 15 '22 21:09 earlygrey

I think it's easier if you commit it in your repo after merging the PR, but it doesn't really matter for me.

Is it easy to do a release after that? Then I could go back to using the official dependency instead of a local jar in my project :)

judos avatar Sep 20 '22 12:09 judos

OK no problem - I'll merge it now and then will make another commit and a release when I get a chance.

By the way you can also just install your local working version of shape drawer to your local maven repository - use the install gradle command. You may have to adjust the version / dependency in your libgdx gradle setup, but then it will use the local installed version as the dependency.

earlygrey avatar Sep 22 '22 21:09 earlygrey

@judos v2.6.0 - let me know if there's an issue

earlygrey avatar Sep 25 '22 19:09 earlygrey