Eduardo Apolinario
Eduardo Apolinario
Tensorflow has been running ok on Macs for a bit. Closing this.
This was fixed by https://github.com/flyteorg/flytekit/pull/1248.
This has been implemented in flytekit 1.3.0.
Closing this in favor of https://github.com/flyteorg/flyte/issues/4505.
no longer reproes.
> fixes [flyteorg/flyte#2570](https://github.com/flyteorg/flyte/issues/2570). > > We're going to need to move these changes into the tensorflow plugin @eapolinario Great, I'll make sure to incorporate those there.
I wasn't aware that we can use `TYPE_CHECKING` inside class definitions, e.g. https://github.com/zen-xu/sunray/blob/c164537614d050a4acd67318913b6092ada799c8/sunray/_internal/dag.py#L49. We could use this trick to provide a different type signature during at type-checking time.
@gaocegege , any estimates of when this might be fixed?
@fg91 , this is awesome, thank you for this feature! In terms of getting this merged, can you merge https://github.com/flyteorg/flyte/pull/5200 and also master? I'll approve after that.
@xshen8888 , can you double-check if you're not being hit by the issue described in https://github.com/flyteorg/flytekit/pull/2151?