André Eriksson

Results 89 comments of André Eriksson

What problem is this change solving for you? I'm not sure this is the right thing to do to in the general case.

Does this work when you run `encore run`? The syntax looks wrong to me. You want `async (): Promise`, no?

No, the actual type definition is here: https://github.com/annexare/Countries/blob/cc382a4045cc7ca1ecd4c479de402dee1ba28929/packages/countries/src/types.ts#L6 Which is a more complex definition using `keyof typeof`: ```typescript export type TCountryCode = keyof typeof countries ```

Hi @dwaynedwards, this assumes the project is deployed via Vercel, which isn't something we require. What is the issue you were running into?

Thanks for the report! This should be fixed in v1.41.11. Can you update and verify? Thanks :)

Can you provide a full daemon log from running `encore run` where it blocks?

Hmm, that's a bit annoying. I can't recall why we added `--preserve-symlinks` in the first place. It would be nice to investigate whether it's still needed.

How are you running it? With `encore run`, or with `encore eject`, or something else?

`allow_origins_with_credentials` doesn't support the wildcard match `*` because that's a security vulnerability in most cases. If you really need this you can use the value `["UNSAFE_ALL_ORIGINS_WITH_CREDENTIALS"]`, but as the name...

Hey, thanks for the PR. I'm not sure this is actually needed. It seems to me that it's perfectly fine to encode integers as header values in the general case,...