vscode-remotehub icon indicating copy to clipboard operation
vscode-remotehub copied to clipboard

Open GH repo resets quick pick focus while browsing

Open Tyriar opened this issue 4 years ago • 6 comments

Again maybe root cause is core. This caused me to open the wrong repo:

recording (15)

Tyriar avatar Mar 23 '21 15:03 Tyriar

Hrm, I think I've seem something kind of similar. Also that search doesn't work very well either. But yeah, that is a core feature.

eamodio avatar Mar 23 '21 15:03 eamodio

@TylerLeonhardt FYI since you're jumping into quick pick soon.

Tyriar avatar Mar 23 '21 15:03 Tyriar

This is probably https://github.com/microsoft/vscode/issues/76193

TylerLeonhardt avatar Mar 23 '21 16:03 TylerLeonhardt

I'd expect items to be added not removed above, if that matters

Tyriar avatar Mar 23 '21 17:03 Tyriar

True yeah this is different. I'm thinking the problem is, @eamodio sets picker.items and that resets the focus back to the top when really it should honor what the activated items were prior.

@eamodio can you do this for me, every time you're about to set items store the activeItems and then set activeItems after setting items. I think that'll fix the problem.

TylerLeonhardt avatar Apr 02 '21 04:04 TylerLeonhardt

Where is this code btw?

TylerLeonhardt avatar Apr 02 '21 04:04 TylerLeonhardt