Ekaterina Aidova
Ekaterina Aidova
@Abdullah-Elkasaby generally, notebook is good, but do you really need so many files and manual model construction inside notebook? Can we just clone model repo and install it instead?
please also rename notebook to keep the same name like notebook subfolder
@Aryan8912 compilation of your pull request failed. I think it maybe due to wrong code style and missed includes for used operations. Could you please fix?
> Can you tell me what type of changes need to be made in the code? @mvafin problems in matmul.cpp if you remove it, it should be resolved
@LucaTamSapienza, no you should not create transformation and register it into frontend (it is different approach for enabling operations used when on direct translation step we have no enough info...
@LucaTamSapienza thanks, looks good. Could you please try to support torch.expm1(x, out=out) case too? ypu can find example how to support out argument in https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/op/erf.cpp#L28 P.S. please also fix code...
@LucaTamSapienza jugging by ci logs, the issue in order for includes, you need sort operations headers in alphabetical order to pass code style check
@LucaTamSapienza looks like now issue with presicion of implemented op: ``` FAILED install/tests/layer_tests/pytorch_tests/test_expm1.py::TestExpm1::test_expm1[ ie_device:CPU - precision:FP32 - inputs:[0, 1, 2, 3, 4, 5] - dtype:float64 ] - AssertionError: dtype validation...
@IlyasMoutawwakil, thank you for your suggestion, that is from what I begin, but problem that we need to know how inputs was duplicated for nonstateful case to duplicate past key...
@IlyasMoutawwakil @echarlaix please take a look one more time, I significantly updated code for reducing overriding beam search methods