klog icon indicating copy to clipboard operation
klog copied to clipboard

Installation of /usr/tests does not respect BUILDROOT

Open hobbes1069 opened this issue 4 years ago • 2 comments

I am working on updating the Fedora package but for packaging purposes everything is installed into a BUILDROOT and installation is done as a normal user which works for the main components:

/usr/lib64/qt5/bin/qmake -install qinstall -exe build/target/klog /builddir/build/BUILDROOT/klog-1.5-1.fc32.x86_64/usr/bin/klog
/usr/lib64/qt5/bin/qmake -install qinstall /builddir/build/BUILD/klog-1.5/src/Changelog /builddir/build/BUILDROOT/klog-1.5-1.fc32.x86_64/usr/share/klog/Changelog
/usr/lib64/qt5/bin/qmake -install qinstall /builddir/build/BUILD/klog-1.5/src/COPYING /builddir/build/BUILDROOT/klog-1.5-1.fc32.x86_64/usr/share/klog/COPYING

But not for tests:

make[2]: Entering directory '/builddir/build/BUILD/klog-1.5/tests/utilities'
mkdir: cannot create directory '/usr/tests': Permission denied

hobbes1069 avatar Apr 09 '21 12:04 hobbes1069

Tests are not to be packaged for users as they are developers tests only. Only the content in the "src" folder is to be packaged for users.

ea4k avatar May 01 '21 16:05 ea4k

I just saw a bunch klog test stuff directly installed on my system under /usr/tests/. Is this a bug or expected behavior?

Here's a list of directories:

/usr/tests/tst_mainwindowinputqso/tst_mainwindowinputqso
/usr/tests/tst_world/tst_world
/usr/tests/tst_locator/tst_locator
/usr/tests/tst_qso/tst_qso
/usr/tests/tst_setuphamlibserialwidget/tst_setuphamlibserialwidget
/usr/tests/tst_setuppageelog/tst_setuppageelog
/usr/tests/tst_mainwindowsattab/tst_mainwindowsattab
/usr/tests/tst_setuphamlibnetworkwidget/tst_setuphamlibnetworkwidget
/usr/tests/tst_mainqsoentrywidget/tst_mainqsoentrywidget
/usr/tests/tst_adif/tst_adif
/usr/tests/tst_dataproxy/tst_dataproxy
/usr/tests/tst_utilities/tst_utilities
/usr/tests/tst_mainwindow/tst_mainwindow

If what I and @hobbes1069 describe is expected behavior, then I propose that this issue may be closed due to not being a bug.

ikbenkous avatar Nov 25 '23 20:11 ikbenkous