exist icon indicating copy to clipboard operation
exist copied to clipboard

Simplify startup code

Open dizzzz opened this issue 8 months ago • 3 comments

The original idea was to remove all old Jetty code.

The PR evolved into a significant rewrite refactoring and cleanup of the original code; Move methods to locations where used, combine functionality in a new Class, split-up the "doIt" method, with readable methods.

dizzzz avatar Apr 13 '25 21:04 dizzzz

The open questions I have

  • shall I make this module start.jar compatible with Java8 ?
    • pro: decent handling of old java versions, with good error message
    • con: bin/startup.sh contains parameters that will stop java8 anyway.
  • start.jar has no external dependencies
    • is that still relevant @wolfgangmm
  • OK to remove all all old jetty-codebase references?
    • all has been removed/refactored and is eXist-db specific

dizzzz avatar Apr 14 '25 08:04 dizzzz

I tried to simplify the startup of appbundler by removing these xml files

  • (old) maven plugin crashes with NPE, cant find reason, is under documented
    • great work of Adam understanding the plugin config
  • idea is to create a (python)script/java module that can update the appbundler xml files
    • this enables updating/changing jar files after release

dizzzz avatar Apr 14 '25 08:04 dizzzz

@dizzzz

  • I don't see much of a point in J8 in this instance, it ll will error one way or the other
  • My guess for relevance of 0 deps would be yes, but @wolfgangmm knows more
  • uhmm yes please, its a new dawn ;-)

duncdrum avatar Apr 14 '25 14:04 duncdrum