exist icon indicating copy to clipboard operation
exist copied to clipboard

Register binary attribute in collection.xconf.xsd

Open joewiz opened this issue 1 year ago • 4 comments

Description:

Closes #5432 by adding schema definitions for the field element's binary attribute in the collection.xconf.xsd schema.

Reference:

#5432

Type of tests:

n/a

joewiz avatar Aug 30 '24 22:08 joewiz

SonarCloud's failure:

Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.20.0:site (default-site) on project exist: Failed to render site: Error generating maven-surefire-report-plugin:3.5.0:report report: Cannot invoke "Object.toString()" because "value" is null -> [Help 1]

The windows-latest checks haven't failed yet; they're still going, 30 minutes after submitting the PR...

joewiz avatar Aug 30 '24 22:08 joewiz

it is a recurring issue.... I guess a plugin update is needed...

dizzzz avatar Aug 31 '24 09:08 dizzzz

@joewiz did you mean issue to link to issue 5342 in the op, I corrected that as I don't see how that would be related

duncdrum avatar Aug 31 '24 09:08 duncdrum

@duncdrum Thanks, yes!

@dizzzz The windows-latest checks finished... after 40 minutes - wow!

joewiz avatar Aug 31 '24 20:08 joewiz

Thanks, all. I've removed true & false from the schema-allowed options and updated my PR branch.

In the issue I linked to the implementation and its tests, which still respectively support and use true & false. I think those fixes should come in a separate PR. If that PR removes these values, it would constitute a breaking change, but of course the PR could also deprecate them, etc.

(I think this PR still counts as a bugfix, since the old schema complained about the very presence of the @binary attribute.)

joewiz avatar Dec 11 '24 13:12 joewiz