exist icon indicating copy to clipboard operation
exist copied to clipboard

[ci] test on Java 11

Open line-o opened this issue 1 year ago • 10 comments

Description:

Test on Java 11

Reference:

Type of tests:

line-o avatar May 13 '24 17:05 line-o

Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8.

adamretter avatar May 13 '24 20:05 adamretter

Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8.

@adamretter unfortunately JDK 8 is no longer available for the Mac OS Github action...

reinhapa avatar May 13 '24 20:05 reinhapa

@adamretter unfortunately JDK 8 is no longer available for the Mac OS Github action...

Is it not possible to have a step that install a JDK? If I recall there is even a pre-build step for this in the GitHub Marketplace that can be used

adamretter avatar May 13 '24 20:05 adamretter

Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8.

I was not aware of that..... or maybe I am. Any idea why?

dizzzz avatar May 14 '24 19:05 dizzzz

Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8.

I was not aware of that..... or maybe I am. Any idea why?

I just ask myself on how much effort are we willing to invest into that branch or should we try getting the next version out of the door?

reinhapa avatar May 14 '24 19:05 reinhapa

Runtime of tests was reasonable between 19 to 27 minutes for the entire test suite on java 11. If there is a known slow-down of exist-db on java 11 I would like to see an issue with some more details to be shared. I would also like to add that we do use the java setup action.

In order for us to make sure that the existdb compiles and runs on java 8 as well we could add a separate test on java8 on linux workflow. How does that sound?

line-o avatar May 16 '24 12:05 line-o

I don't understand the point of this. eXist-db 6 targets Java 8, so changing CI to Java 11 makes no sense

adamretter avatar Jul 25 '24 11:07 adamretter

I don't understand the point of this. eXist-db 6 targets Java 8, so changing CI to Java 11 makes no sense

@adamretter I think using Java 11 to produce Java 8 byte code should be still ok instead of having investing a lot of time to handle an alternative Java setup instead. I think it would be better to consentrate on the next release instead and not wasting to much time in doing work-arounds for no longer supported build JDKs IMHO...

reinhapa avatar Jul 25 '24 15:07 reinhapa

https://github.com/marketplace/actions/maven-jdk8-for-monorepo-projects ?

dizzzz avatar Jul 30 '24 10:07 dizzzz

I read/hear that the performance decline of java11 has been addresses in the JDK some time ago.

dizzzz avatar Sep 20 '24 17:09 dizzzz