exist icon indicating copy to clipboard operation
exist copied to clipboard

Published 20 hours ago • verified publisher icon eXist-db

[refactor] Restructure RangeIndexAttributeCondition

Open line-o opened this issue 1 year ago • 4 comments

Description:

These private properties of RangeIndexAttributeCondition

  • String value
  • boolean caseSensitive
  • boolean numericComparison
  • Double numericValue
  • String lowercaseValue
  • Pattern pattern

were replaced by

  • boolean commutative
  • boolean commutativeNegate
  • Predicate<String> indexPredicate
  • Predicate<AtomicValue> queryPredicate

indexPredicate and queryPredicate are references to one-line lambdas. Before, a lot of switching and checking happened on each call to find and matches

line-o avatar Mar 26 '24 10:03 line-o

Quality Gate Failed Quality Gate failed

Failed conditions
64.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 28 '24 15:03 sonarqubecloud[bot]

@reinhapa I believe the changes you requested were addressed in the meantime

line-o avatar May 02 '24 19:05 line-o

@reinhapa could you please re-review, I believe it's good to go

line-o avatar May 23 '24 21:05 line-o

commutativeNegate could be renamed to converse (see https://en.m.wikipedia.org/wiki/Converse_relation and https://en.m.wikipedia.org/wiki/Inequality_(mathematics) ).

line-o avatar Jul 31 '24 09:07 line-o