exist icon indicating copy to clipboard operation
exist copied to clipboard

Published 20 hours ago • verified publisher icon eXist-db

Preserve XML Declaration

Open adamretter opened this issue 3 years ago • 1 comments

Requires Java 17 support to be merged first - https://github.com/eXist-db/exist/pull/4574 (and so at this time it contains all commits of that PR also).

This Pull Request causes an XML Declaration to be preserved if it s present. This means that it will be stored into the database if a document that is stored has an XML Declaration, and it will be retrieved at serialisation time.

This necessarily changes the on-disk storage format of the collections.dbx, and so increments the file version (which is checked at startup).

  • This required me to also release new versions of Apache Xerces 2 which supports the extended SAX API of Java 14+ - https://repo1.maven.org/maven2/org/exist-db/thirdparty/xerces/xercesImpl/2.12.2/ (see: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8230814)

adamretter avatar Sep 28 '22 23:09 adamretter

I'd suggest to postpone the review, as (like you said) content of other PRs are there.

dizzzz avatar Sep 30 '22 09:09 dizzzz

Please consider choosing a different base branch for others to be able to see the actual change-set.

line-o avatar Oct 11 '22 11:10 line-o

Please consider choosing a different base branch for others to be able to see the actual change-set.

@line-o As this requires Java 17, and therefore requires that PR (and hence branch), I can't see another option... perhaps you have a suggestion?

adamretter avatar Oct 11 '22 12:10 adamretter

Yes. As I wrote, you change this PRs base branch. The base branch of this PR is the Java17 one.

line-o avatar Oct 11 '22 12:10 line-o

Yes. As I wrote, you change this PRs base branch. The base branch of this PR is the Java17 one.

@line-o That is not possible as the base branch is not within this repo.

adamretter avatar Oct 11 '22 12:10 adamretter

I believe it is ok to make an exception for the Java17 branch and publish it here.

line-o avatar Oct 11 '22 12:10 line-o

LGTM some JVM issues though?

dizzzz avatar Dec 03 '22 11:12 dizzzz

some JVM issues though?

@dizzzz How do you mean please?

adamretter avatar Dec 05 '22 15:12 adamretter

some JVM issues though?

@dizzzz How do you mean please?

There seems to be only a unused dependency issue under JDK 17: https://github.com/eXist-db/exist/actions/runs/3621375771/jobs/6104735443#step:4:15682

reinhapa avatar Dec 05 '22 19:12 reinhapa

There seems to be only a unused dependency issue under JDK 17: https://github.com/eXist-db/exist/actions/runs/3621375771/jobs/6104735443#step:4:15682

@reinhapa @dizzzz should be fixed now.

adamretter avatar Dec 05 '22 22:12 adamretter

image ah right. dependency thingy

dizzzz avatar Dec 06 '22 08:12 dizzzz

@reinhapa not sure anymore, I guess I misinterpreted the dependency thing

dizzzz avatar Dec 06 '22 08:12 dizzzz

I hope that xalan-2.7.3 will be released anytime soonish https://www.mail-archive.com/[email protected]/ - or we should be able to refactor it away.

dizzzz avatar Dec 06 '22 08:12 dizzzz

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 56 Code Smells

64.3% 64.3% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 06 '22 12:12 sonarqubecloud[bot]

I hope that xalan-2.7.3 will be released anytime soonish https://www.mail-archive.com/[email protected]/ - or we should be able to refactor it away.

@dizzzz I think I can go one better - https://github.com/eXist-db/exist/pull/4643 ;-)

adamretter avatar Dec 07 '22 19:12 adamretter

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

74.0% 74.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Feb 06 '23 18:02 sonarqubecloud[bot]