exist [5.x.x] backport of encoding and file module fixes

[5.x.x] backport of encoding and file module fixes

Open line-o opened this issue 2 years ago • 11 comments

Description:

Backport a number of fixes from develop regarding default encoding and file:sync. This PR also adds and enhances file module tests.

Reference:

refs #4321 refs #4311 refs #4290

Type of tests:

XQSuite tests

Apr 09 '22 14:04 line-o

@line-o Once this is rebased, we could merge this.

In future when creating a backport, can you do so as a 1-1 mapping between PRs please. i.e. if you want to backport a PR then create a single backport PR which contains only those changes and uses the same commit messages. Please do not mix multiple original PRs into a single backport PR.

This helps when we look back at the histories, so that we can clearly and easily compare the two branches and understand what was backported from where. Thanks

Apr 15 '22 08:04 adamretter

I can't follow. What made a rebase necessary @dizzzz? @adamretter this is exactly what I did cherry-picking each commit and only modify those that needed manual changes.

Apr 15 '22 10:04 line-o

Apr 15 '22 10:04 dizzzz

Just to put that in writing, later commits changed the codebase in the exact same places as this PR and those were merged first.

Apr 15 '22 11:04 line-o

This PR allows edits. So interested parties can resolve that conflict. As I have no stake in this other than I wanted to help I will not devote more of my free time on this.

Apr 15 '22 12:04 line-o

sorry to hear :-( it is just one file. somehow my git client failed working.... hmmm

Apr 18 '22 18:04 dizzzz

SonarCloud Quality Gate failed.