Fast-DDS
Fast-DDS copied to clipboard
[22593] Include all example tests in windows CI
Description
This PR includes all the remaining examples into the windows ci testing. Some considerations worth mentioning:
test_configurationwas splitted into3suite of tests in order not to exceed the300timeout seconds configured in colcon.- IPv6 test cases were disabled in both Windows and Ubuntu. Windows does not support it and Docker in Ubuntu CI supports only the ipv6 localhost (I tried to enable the experimental features but gave error). Since Docker in Windows neither supports
network_mode: host, some examples were refactored to use customnetworkwith fixed ips (for instance, thediscovery_serverexample one) - Some test cases were disabled in some examples in windows to avoid flakiness. Specially those making use of SHM or DataSharing among dockers. The issue will keep being being investigated in a follow up PR.
- The Python
subprocess.check_outputdoes not properly work in Windows, when thetimeoutexpires, subprocesses are not killed. This led me to also disable thetimeouttest cases for some of the example tests. - Some extra additions were made to the
Publishersto force waiting forackin the first sample and mitigate flakiness.
Note: This PR should be merged after
- #5849
Contributor Checklist
- [X] Commit messages follow the project guidelines.
- [X] The code follows the style guidelines of this project.
- N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
- N/A Any new/modified methods have been properly documented using Doxygen.
- N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
- N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
- N/A Changes are API compatible.
- N/A New feature has been added to the
versions.mdfile (if applicable). - N/A New feature has been documented/Current behavior is correctly described in the documentation.
- N/A Applicable backports have been included in the description.
Reviewer Checklist
- [ ] The PR has a milestone assigned.
- [ ] The title and description correctly express the PR's purpose.
- [ ] Check contributor checklist is correct.
- [ ] If this is a critical bug fix, backports to the critical-only supported branches have been requested.
- [ ] Check CI results: changes do not issue any warning.
- [ ] Check CI results: failing tests are unrelated with the changes.
In the delivery_mechanisms example I forced to ack the first and the last sample (just if samples >0). Hopefully it completely solves the flakiness of the test. In my local I run it 20 times without failure 🤞🏻