Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

Make status changes thread-safe

Open Carlosespicur opened this issue 10 months ago • 0 comments

Description

It has been notified that multiple threads can access simultaneously to RTPS listener callbacks in DataWriterImpl/DataReaderImpl, causing multiple status changes before notifying them to DataWriterListener/DataReaderListener.

This PR fix the problem making status changes and notifications thread-safe.

Contributor Checklist

  • [x] Commit messages follow the project guidelines.
  • [x] The code follows the style guidelines of this project.
  • [ ] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen. -N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • [ ] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [x] Changes are API compatible. -N/A New feature has been added to the versions.md file (if applicable). -N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • [ ] Applicable backports have been included in the description.

Reviewer Checklist

  • [ ] The PR has a milestone assigned.
  • [ ] The title and description correctly express the PR's purpose.
  • [ ] Check contributor checklist is correct.
  • [ ] If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • [ ] Check CI results: changes do not issue any warning.
  • [ ] Check CI results: failing tests are unrelated with the changes.

Carlosespicur avatar Feb 25 '25 05:02 Carlosespicur