Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[21959] `SHM` transport in `LARGE_DATA` modes should be properly guarded

Open Mario-DL opened this issue 1 year ago • 0 comments

Description

Compilation with FASTDDS_SHM_TRANSPORT_DISABLED and SHM_TRANSPORT_BUILTIN should properly manage the shm transport in LARGE_DATA modes.

Note: we may forward port this PR to 3.x

Contributor Checklist

  • [ ] Commit messages follow the project guidelines.
  • [ ] The code follows the style guidelines of this project.
  • [ ] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [ ] Any new/modified methods have been properly documented using Doxygen.
  • [ ] Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • [ ] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [ ] Changes are API compatible.
  • [ ] New feature has been added to the versions.md file (if applicable).
  • [ ] New feature has been documented/Current behavior is correctly described in the documentation.
  • [ ] Applicable backports have been included in the description.

Reviewer Checklist

  • [ ] The PR has a milestone assigned.
  • [ ] The title and description correctly express the PR's purpose.
  • [ ] Check contributor checklist is correct.
  • [ ] If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • [ ] Check CI results: changes do not issue any warning.
  • [ ] Check CI results: failing tests are unrelated with the changes.

Mario-DL avatar Oct 22 '24 07:10 Mario-DL