Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

[21861] clean.py does not clean up fast_datasharing* files

Open ma30002000 opened this issue 1 year ago • 1 comments

Is there an already existing issue for this?

  • [X] I have searched the existing issues

Expected behavior

clean.py will clean up any orphaned resources in /dev/shm

Current behavior

clean.py does not clean up fast_datasharing* files that are created when data-sharing delivery is active (see DataSharingNotification.hpp)

Steps to reproduce

Setup up two processes with communication adhering to data sharing constraints. Forcibly kill them. Run clean.y.

Fast DDS version/commit

master, 2.14.3, etc.

Platform/Architecture

Ubuntu Focal 20.04 amd64

Transport layer

Shared Memory Transport (SHM), Data-sharing delivery

Additional context

It is unclear to me if the same mechanisms that are used cleaning the other orphaned files can be re-used (delete if file can be locked exclusively).

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

ma30002000 avatar Oct 07 '24 13:10 ma30002000

Hi @ma30002000, thanks for your report. I have successfully reproduced it. We will address it in the following weeks.

JesusPoderoso avatar Oct 14 '24 06:10 JesusPoderoso

Hello @ma30002000, thanks for your patience.

The behavior you described was the intended design when the tool was initially developed. However, we have internally agreed to include this as a new feature in future releases.

In the meantime, you can achieve the desired behavior by running the following command after killing the processes: rm -f /dev/shm/fast*

We’ll notify you as soon as the new feature is ready. Thank you for your feedback!

cferreiragonz avatar Dec 10 '24 06:12 cferreiragonz

Hi @ma30002000, #5549 has been just merged which should address the issue. Marking it as completed

Mario-DL avatar Jan 16 '25 08:01 Mario-DL