Fast-DDS icon indicating copy to clipboard operation
Fast-DDS copied to clipboard

Make more flexible EDP::valid_matching with TypeInformation [21260]

Open richiware opened this issue 7 months ago • 0 comments

Description

Currently EDP::valid_matching expects both TypeInfomation are exactly equal. This PR makes this checking more flexible, allowing to pass when they have only EK_COMPLETE or EK_MINIMAL equals.

Depends on:

  • #4985

Contributor Checklist

  • [x] Commit messages follow the project guidelines.
  • [x] The code follows the style guidelines of this project.
  • [x] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [x] Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • [x] The PR has a milestone assigned.
  • [x] The title and description correctly express the PR's purpose.
  • [x] Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • [x] Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

richiware avatar Jun 26 '24 07:06 richiware